Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tab: Table update and formatting code cleanup needed #136

Closed
synrg opened this issue Nov 1, 2020 · 1 comment
Closed

tab: Table update and formatting code cleanup needed #136

synrg opened this issue Nov 1, 2020 · 1 comment
Assignees
@synrg

Comments

@synrg
Copy link
Collaborator

synrg commented Nov 1, 2020 •
edited
Loading

The current approach for updating and formatting tables is causing pain in a number of areas. Addressing this code smell is a blocker for getting anything more done with tables (https://github.com/synrg/dronefly/projects/1). The data representation and presentation layers of the code are not sufficiently separated from each other, making changes like #135 tricky, the code contains a lot of copypasta, and it is susceptible to races (#101).
@synrg synrg self-assigned this Nov 1, 2020
@synrg synrg mentioned this issue Nov 15, 2020
Closed
@synrg
Copy link
Collaborator Author

synrg commented Jan 22, 2021

I probably should've updated this issue instead of creating issue #141 . Oh well. What's done is done.

@synrg synrg closed this as completed Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@synrg synrg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@synrg