Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdk: fixes for getMaxTradeSizeUSDCForPerp #1340

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

sdk: fixes for getMaxTradeSizeUSDCForPerp #1340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions sdk/src/user.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2728,7 +2728,7 @@
lpBuffer
);

if (maxPositionSize.gte(ZERO)) {
if (maxPositionSize.gt(ZERO)) {
if (oppositeSizeLiabilityValue.eq(ZERO)) {
// case 1 : Regular trade where current total position less than max, and no opposite position to account for
// do nothing
Expand All @@ -2750,8 +2750,18 @@
);
const totalCollateral = this.getTotalCollateral();
const marginRequirement = this.getInitialMarginRequirement();

let marginRatio = new BN(

Check failure on line 2754 in sdk/src/user.ts

View workflow job for this annotation

GitHub Actions / yarn-lint 

'marginRatio' is never reassigned. Use 'const' instead
calculateMarketMarginRatio(
market,
currentPosition.baseAssetAmount.abs(),
'Initial',
this.getUserAccount().maxMarginRatio,
this.isHighLeverageMode()
)
);
const marginFreedByClosing = perpLiabilityValue
.mul(new BN(market.marginRatioInitial))
.mul(marginRatio)
.div(MARGIN_PRECISION);
const marginRequirementAfterClosing =
marginRequirement.sub(marginFreedByClosing);
Expand Down
Loading