Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notes from Mozilla's review of the add-on #33

Open
drewrwilson opened this issue Sep 18, 2015 · 0 comments
Open

Notes from Mozilla's review of the add-on #33

drewrwilson opened this issue Sep 18, 2015 · 0 comments

Comments

@drewrwilson
Copy link
Owner

As part of submitting it to the Mozilla add-on store, they do a review of the code. Here's what feedback they gave:

Your preliminary review request has been approved.

Please note the following for the next update:

  1. If the addEventListener() (or JQuery .on) is used once (e.g. for 'load', 'DOMContentLoaded'), it is good practice to removeEventListener() (or JQuery .off) as soon as its function is called and free the resources.
    elem.addEventListener(event, myfunction, false);
    function myfunction() {
    elem.removeEventListener(event, myfunction, false); // remove listener, no longer needed
    // rest of the function code
    }

elem.addEventListener(event, function myfunction(event){
elem.removeEventListener(event, myfunction, false); // remove listener, no longer needed
// rest of the function code
},false);

  1. Add-on contains duplicate/hidden/unused/unnecessary files or folders. These complicate the review process and may contain sensitive information about the system you created the XPI on. Please correct your packaging process so that these files aren't included.

__MACOSX ... and its content
chrome/.DS_Store

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant