Reflections: dimensions_by_day not parsed correctly

[ravjotbrar]

Looked further into the macro that should handle this logic and only case that’s handled is if dimensions_by_day is None.

Looking at granularity of a datetime col after specifying it in dimensions and dimensions_by_day should change to 'Date' rather than Original.

[LuVlk]

Although documentation says the macro argument is called dimensions_by_day (See: https://github.com/dremio/dbt-dremio/wiki/Using-Materializations-with-Dremio#reflections), the argument is (in version 1.7.0) actually called by_day_dimensions (See:

dbt-dremio/dbt/include/dremio/macros/materializations/reflection/create_reflection.sql

Line 41 in e7b087e

display=none, dimensions=none, by_day_dimensions=none, measures=none) %}

)

The example in the Wiki should be

{{ config(materialized='reflection', 
reflection_type='aggregate', 
dimensions=['Datetime0'], 
by_day_dimensions=['Datetime0'], 
measures=['Num3', 'Int2'], 
computations=['MIN,SUM','COUNT'], 
arrow_cache=true) }}

-- depends_on: {{ ref('my_anchor') }}

[bcmeireles]

Approached in #256