Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support auth enabled redis-cluster, consumer based routing, client rate limiting headers #16

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

chaitanya14
Copy link

@chaitanya14 chaitanya14 commented Dec 13, 2022

Summary

Added functionality to support authentication enabled redis-cluster, consumer based routing and rate-limiting client headers.

Full changelog

  • Auth enabled redis-cluster.
  • Consumer based routing.
  • Rate-limiting client headers.
  • Added unit tests for schema validation
  • Added integration tests for consumer based routing and rate limiting client headers.

Issues resolved

#15

@jeremyjpj0916
Copy link

Nice to see yah implemented what we were discussing earlier in the day. That should do the trick in terms of what the redis client needs, but only thing not sure of is the nil case if the client will do anything whacky on connection but looks like it checks for it being a string and nil would keep it out of trying to use any kinda auth.

@chaitanya14 chaitanya14 changed the title Support auth enabled redis-cluster Support auth enabled redis-cluster, consumer based routing, client rate limiting headers Dec 16, 2022
@chaitanya14
Copy link
Author

Pongo tests results:

image

@chirag-manwani
Copy link
Collaborator

@chaitanya14 Can you split this into multiple PRs each with its own set of tests? That would be easier to track and manage.
You can add 3 PRs one for each of the following features-
Auth enabled redis-cluster.
Consumer based routing.
Rate-limiting client headers.

@chirag-manwani
Copy link
Collaborator

@chaitanya14 For easier review can you please split the PR into multiple PRs as explained above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants