Skip to content
This repository has been archived by the owner on Feb 22, 2024. It is now read-only.

Mazda TI support #38

Open
RedFox102 opened this issue Feb 7, 2023 · 6 comments
Open

Mazda TI support #38

RedFox102 opened this issue Feb 7, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@RedFox102
Copy link
Contributor

Can we add support for the popular Mazda TI (1.0)? I asked permission from RyleyMCC, the guy behind the TI and TI 2.0, and he has no problem with it. I saw someone was doing some work on this on the branch mazda-ti, but the TI related code is technically only on private repos, so I thought it would be best to get permission before putting it on a public repo like this.

@RedFox102 RedFox102 added the enhancement New feature or request label Feb 7, 2023
@eFiniLan
Copy link
Member

Can we add support for the popular Mazda TI (1.0)? I asked permission from RyleyMCC, the guy behind the TI and TI 2.0, and he has no problem with it. I saw someone was doing some work on this on the branch mazda-ti, but the TI related code is technically only on private repos, so I thought it would be best to get permission before putting it on a public repo like this.

Hi @RedFox102, thanks for your comment, it's been a while but I remembered the guy who provided the code to us has asked permission to upstream the code to dp.

I'm happy to take it down if that was not the case.

@RedFox102
Copy link
Contributor Author

RedFox102 commented Feb 13, 2023

RyleyMCC (creator of the TI) said he didn't know anything about it, so I don't think whoever provided the code had permission, or if they did maybe he forgot about it. I did however ask permission before I posted this, so now it's definitely ok to do.

I believe your mazda_ti branch is done, we just need changes to panda, cereal and opendbc for the TI to work. I can do a PR for each of those later this week when I have time, mostly I just need help making a toggle to enable/disable TI support, as I don't quite know how to do that, or if I am even able to since I know some of the UI stuff is closed source.

I can probably also give you direct access to the TI repo if you want to look through the code.

@RedFox102
Copy link
Contributor Author

@eFiniLan I created PR's for cereal, opendbc, panda, and dp-devel. I combined your changes on the branch mazda_ti with what I noticed was missing, there is just a small conflict that didn't show up until I submitted the last PR, I'm not sure what happened there.

Anyway, give them a look when you get a chance and let me know if it looks okay to you. Ryley has over a hundred of these TI's in users hands now, and I think a lot of those people would love to use dragonpilot. :)

@MoreTore
Copy link
Contributor

MoreTore commented Feb 23, 2023

ryleymcc here using alt account. I would love for Dp to have TI support. I have released a new TI2 for the new Mazdas and will also be supporting the 10th gen honda civic. I hope to have that code upstreamed to Dp as well!

Edit: I see this branch created last year https://github.com/dragonpilot-community/dp-devel/tree/mazda_ti

@eFiniLan
Copy link
Member

@MoreTore thanks for offering the support, looking forward to integrating that into DP ❤️

@RedFox102 thanks for the PRs, I will start reviewing the code in the next couple of days (we are having a long weekend this week hehe), will give you some feedback if needed.

ideally, I hope the integration will not affect other vehicle models and be modulized as much as possible so it's easier for us to upgrade to the latest op version easily, lets see how it will go! 👍

@RedFox102
Copy link
Contributor Author

I want to stress that the code is mostly ryleymcc's, and some is from jacar I think (if I'm missing anyone, let me know). I'm slowly learning python, but I haven't done anything significant worth taking credit for.

I want to really dive into this over the weekend though and do what I can! Looking forward to it, it's going to be a great thing for Mazda users.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants