You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The code referenced below requires a file to both have the proper file name ending and for its content to be proper SBML/SBGN.
This seems unnecessarily restrictive to me, as the second check is arguably stronger - i.e. this could well do with "logical or" instead of "and".
My two cents:
Yes, a logical or would be less restrictive and also detect correct files even if they have a different extension.
However, please consider the architectural design of those filefilters. Aren't they applied as soon as the browser window is opening a folder? Consider a folder with thousands of files. The second check would require the filefilter to open all those files in order to do a content base check.
The code referenced below requires a file to both have the proper file name ending and for its content to be proper SBML/SBGN.
This seems unnecessarily restrictive to me, as the second check is arguably stronger - i.e. this could well do with "logical or" instead of "and".
https://github.com/draeger-lab/SysBio/blob/2d6520704440397ab7fcf0b59d6adbdd82942b1a/src/de/zbit/io/filefilter/SBFileFilter.java#L911C1-L925C4
This came up in downstream development on the ModelPolisher.
The text was updated successfully, but these errors were encountered: