Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProcessManager doesn't handle all processes which terminated with an error correctly #83

Open
dkarlovi opened this issue Sep 21, 2022 · 0 comments

Comments

@dkarlovi
Copy link
Collaborator

Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no
Branch? master

Currently, when a process fails with an error, process manager will claim it's still running. From the users' POV, this seems like the process "stalled", but it actually died.

There's several ways we could do this:

  1. check when was the last update from the process, if it wasn't updated in some timeout, we assume it died and mark it as such, this only works for Data Definitions AFAIK
  2. actually write down the PID and monitor the process' STDOUT, STDERR and if it still exists, this is much more robust, but is more complex
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant