Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in void Matrix<T, M, N>::invert() in "include/detail/matrix-inl.h" #329

Open
superbignut opened this issue Oct 4, 2023 · 1 comment
Assignees

Comments

@superbignut
Copy link

Function invert() use four parts(search, swap, compute, scale) in a loop to solve the inverse of a matrix.
But the a(j, j) in the code "T c = 1 / a(j, j);" of the scale part sometimes equals to 0.
for example:
[[3,1,0],[2,1,1],[1,0,0]]
In my opinion, scale part need to be used after the loop to ensure all a(j,j)!=0.

@doyubkim
Copy link
Owner

Thanks for reporting this! Let me take a look

@doyubkim doyubkim self-assigned this Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants