Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could add warn for unused parameters in config? #138

Closed
ykuc opened this issue Dec 8, 2024 · 2 comments
Closed

Could add warn for unused parameters in config? #138

ykuc opened this issue Dec 8, 2024 · 2 comments

Comments

@ykuc
Copy link
Contributor

ykuc commented Dec 8, 2024

No description provided.

@ykuc ykuc changed the title Could add warn for unused parameters? Could add warn for unused parameters in config? Dec 8, 2024
@ykuc
Copy link
Contributor Author

ykuc commented Dec 21, 2024

It marks all fields for yt dest in unused fields.
Is this result ok?

dst:
  type: yt
  params: |
    {
      "path": "//home/cdc",
      "cluster": "yt-backend:80",
      "cellbundle": "default",
      "primarymedium": "default"
    }
./binaries/trcli validate --transfer=./examples/pg2yt/transfer_cdc_embed.yaml

2024-12-21T18:20:48.228+0100    INFO    trcli/config/config.go:147      config for: pg source has [IgnoreUnknownTables SnapshotDegreeOfParallelism DBLogEnabled ChunkSize IsHomo TLSFile DesiredTableSize BatchSize KeeperSchema IgnoreUserTypes EmitTimeTypes ConnectionID DBTables SecurityGroupIDs Host EnableTLS SubNetworkID CollapseInheritTables PreSteps PgDumpCommand SlotID UseFakePrimaryKey ExcludedTables SlotByteLagLimit UsePolling AutoActivate PostSteps ExcludeDescendants SnapshotSerializationFormat ShardingKeyFields Cluster MaxBufferSize NoHomo] unset fields
2024-12-21T18:20:48.228+0100    INFO    trcli/config/config.go:162      config for: yt destination has [primarymedium cellbundle cluster path] unused fields
2024-12-21T18:20:48.228+0100    INFO    trcli/config/config.go:165      config for: yt destination has [Model _pushWal] unset fields
2024-12-21T18:20:48.228+0100    INFO    trcli/validate/validate.go:32   pg 👌source config
2024-12-21T18:20:48.228+0100    INFO    trcli/validate/validate.go:38   yt 👌destination config
dst:
  type: yt
  params:
    Path: "//home/cdc"
    Cluster: "yt-backend:80"
    Cellbundle: "default"
    Primarymedium: "default"
./binaries/trcli validate --transfer=./examples/pg2yt/transfer_cdc_embed.yaml

2024-12-21T18:32:09.314+0100    INFO    trcli/config/config.go:147      config for: pg source has [SlotByteLagLimit AutoActivate ExcludeDescendants DesiredTableSize DBLogEnabled SnapshotSerializationFormat ConnectionID DBTables PgDumpCommand SlotID UseFakePrimaryKey IgnoreUnknownTables EmitTimeTypes Host SecurityGroupIDs IsHomo SnapshotDegreeOfParallelism ChunkSize TLSFile ExcludedTables PreSteps IgnoreUserTypes MaxBufferSize ShardingKeyFields Cluster PostSteps BatchSize SubNetworkID CollapseInheritTables UsePolling NoHomo EnableTLS KeeperSchema] unset fields
2024-12-21T18:32:09.315+0100    INFO    trcli/config/config.go:162      config for: yt destination has [Primarymedium Cellbundle Cluster Path] unused fields
2024-12-21T18:32:09.315+0100    INFO    trcli/config/config.go:165      config for: yt destination has [Model _pushWal] unset fields
2024-12-21T18:32:09.315+0100    INFO    trcli/validate/validate.go:32   pg 👌source config
2024-12-21T18:32:09.315+0100    INFO    trcli/validate/validate.go:38   yt 👌destination config

@laskoviymishka
Copy link
Contributor

That's a separate issue specifically with YT Provider, will be fixed here: #151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants