Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only updated one project #932

Open
linwood-rancho opened this issue Nov 11, 2021 · 7 comments
Open

Only updated one project #932

linwood-rancho opened this issue Nov 11, 2021 · 7 comments
Labels
community reported Triaged Label to show that UA team has triaged this issue.

Comments

@linwood-rancho
Copy link

Problem encountered on https://dotnet.microsoft.com/platform/upgrade-assistant/tutorial/install-upgrade-assistant
Operating System: windows

Provide details about the problem you're experiencing. Include your operating system version, exact error message, code sample, and anything else that is relevant.

I just tried to up a Solution with two projects that were built on .NET 5 to .NET 6. One of the projects seemed to upgrade just fine. But the other project is still targeting .NET 5. I have tried to copy that project to another folder and re-analyze, but it just skips the upgrade and jumps to Finalize Upgrade.

Also when I did the original migration of the solution, it only made a back up of the first project I had marked as the entry point.

@twsouthwick
Copy link
Member

Can you provide some details as to what the output looks like and what the project types are?

@sunandabalu sunandabalu added community reported Triaged Label to show that UA team has triaged this issue. labels Nov 11, 2021
@linwood-rancho
Copy link
Author

I am sorry I am not sure what you are asking for?

One project is a console app that uses the other project in the solution. The second project is a class library that makes some http client calls. The console app portion did get upgraded. The class library did not get updated. Here is what I see on the cmd window. As you can see after I picked the entry point for the solution, it just wants to Finalize the upgrade.

When I look at the project properties it is still using NET 5.

cheers

Upgrade Steps

Entrypoint: C:\MSTC_GIT\Outside Contrators\foundry-import - Copy\MSTC.Foundry.Sync\Everfi.Foundry\Everfi.Foundry.csproj

[15:17:46 INF] Recommending TFM net5.0 because of dependency on project C:\MSTC_GIT\Outside Contrators\foundry-import - Copy\MSTC.Foundry.Sync\Everfi.Foundry\Everfi.Foundry.csproj
[15:17:46 INF] Recommending executable TFM net6.0 because the project builds to an executable

  1. [Next step] Finalize upgrade

Choose a command:

  1. Apply next step (Finalize upgrade)
  2. Skip next step (Finalize upgrade)
  3. See more step details
  4. Configure logging
  5. Exit

1
[15:20:26 INF] Applying upgrade step Finalize upgrade
[15:20:26 INF] Upgrade step Finalize upgrade applied successfully
Please press enter to continue...

[15:20:28 INF] Upgrade has completed. Please review any changes.
[15:20:28 INF] No state to save

@CodeWithPraveen
Copy link

@linwood-rancho I'm facing the exact same issue you reported. Did you manage to make it work?

@matdv
Copy link

matdv commented Nov 22, 2021

I had the same issue. Turns out, that upgrades from .NET Core are currently not supported.
See https://docs.microsoft.com/en-us/dotnet/core/porting/upgrade-assistant-overview?WT.mc_id=dotnet-35129-website

@linwood-rancho
Copy link
Author

@CodeWithPraveen
I had inherited this project from a consultant and had not really dug into it. As my initial comment indicated the .exe was converted just fine. It turned out the second project in the solution was nothing more than a collection of DTO classes to work with some JSON responses. There was no logic in any of the classes. So I tried to just flip the framework from .NET 5 to .NET 6 and compiled it. And that worked. I was able to run the program with test data, and all was good.

@CodeWithPraveen
Copy link

@CodeWithPraveen
I had inherited this project from a consultant and had not really dug into it. As my initial comment indicated the .exe was converted just fine. It turned out the second project in the solution was nothing more than a collection of DTO classes to work with some JSON responses. There was no logic in any of the classes. So I tried to just flip the framework from .NET 5 to .NET 6 and compiled it. And that worked. I was able to run the program with test data, and all was good.

@linwood-rancho
I did exactly the same. Manually changed the class library from .net5.0 to .net6.0, and it was fine. I was curious to know why it didn't upgrade that project although the other main project got converted.

As @matdv highlighted above, it appears this tool is more towards upgrading .NET Framework projects. Hence, it isn't fully supporting previous version of .NET Core to .NET 6.

Thanks for your reply and details.

@CodeWithPraveen
Copy link

I had the same issue. Turns out, that upgrades from .NET Core are currently not supported.
See https://docs.microsoft.com/en-us/dotnet/core/porting/upgrade-assistant-overview?WT.mc_id=dotnet-35129-website

That explain the first part. Thanks for sharing that link. I missed the part that it supports only .NET Framework.

But, I'm still curious as to how the main Web API project got upgraded properly from .NET 5 to .NET 6 including the packages, but the referenced .NET 5 class library is getting skipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community reported Triaged Label to show that UA team has triaged this issue.
Projects
None yet
Development

No branches or pull requests

5 participants