-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[outerloop] RegexKnownPatternTests.RecreationalRegex_Rectangle either fails with Specified argument was out of the range of valid values.
or times out
#98962
Comments
Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions Issue DetailsError Blob{
"ErrorMessage": "",
"BuildRetry": false,
"ErrorPattern": "System\.Text\.RegularExpressions\.Tests\.RegexKnownPatternTests\.RecreationalRegex_Rectangle.+\[FAIL\]",
"ExcludeConsoleLog": true
} Reproduction Steps
|
Specified argument was out of the range of valid values.
or times outSpecified argument was out of the range of valid values.
or times out
@carlossanlop, do we know how long that issue has been there, and thus how long this regex issue may have been there but hidden? |
I logged the outerloop issue I just fixed back in December 14: #96035 |
Meaning this has been going on only since Dec 14, or it may have been going on before then as well and we only noticed then? |
Unfortunately, I do not know if it had been happening before the issue I fixed. |
Oh sorry, I thought you meant the regex issue. Let me check... |
It might have started affecting outerloop after the initial PR introducing XUnitLogChecker support, which was merged on November 14 2023: #93906 |
This appears to have been regressed by #97463. Still need to investigate why/how... |
Figured it out, thanks to #98472, which when I re-enabled the test flagged a stack imbalance. The bug is that #97463 is in some situations pushing a capture position onto the stack if there's a negative lookaround containing captures and is inside of a loop, but it's not popping that state off the stack if the body of the lookaround matches, which for a negative lookaround is actually failure. Will put up a PR tomorrow. |
Fixed by #99424 |
This failure was uncovered in outerloop after fixing an issue that was affecting all runs and hiding other failures: #97135
Error Blob
Reproduction Steps
Build: https://dev.azure.com/dnceng-public/public/_build/results?buildId=580195
Queues:
windows-x86 Release CoreCLR_Release
linux_musl-x64 Debug CoreCLR_Debug
Job results:
Log files:
Output:
Known Issue Error Message
Fill the error message using step by step known issues guidance.
The text was updated successfully, but these errors were encountered: