Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: SVE Cleanup - Simplify handling of RMW intrinsics in LSRA #104842

Closed
TIHan opened this issue Jul 12, 2024 · 2 comments · Fixed by #107459
Closed

JIT: SVE Cleanup - Simplify handling of RMW intrinsics in LSRA #104842

TIHan opened this issue Jul 12, 2024 · 2 comments · Fixed by #107459
Assignees
@a74nh
Labels
arch-arm64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI arm-sve Work related to arm64 SVE/SVE2 support in-pr There is an active PR which will close this issue when it is merged Priority:2 Work that is important, but not critical for the release
Milestone
10.0.0

Comments

@TIHan
Copy link
Contributor

TIHan commented Jul 12, 2024 •
edited
Loading

Discussion: #104704 (comment)

BuildHWIntrinsic in lsraarm64.cpp is getting a little complicated, especially when it comes to handling RMW intrinsics and when ConditionalSelect wraps a RMW intrinsic.

The logic that handles the RMW intrinsics makes assumptions on which operand on the intrinsic is the RMW node based on flags. Instead, as mentioned in the discussion, we really just need to have a function that tells us which operand is the RMW node and then BuildHWIntrinsic will know how to handle it in a general way.
@TIHan TIHan added this to the 9.0.0 milestone Jul 12, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 12, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@JulieLeeMSFT JulieLeeMSFT added arm-sve Work related to arm64 SVE/SVE2 support Priority:3 Work that is nice to have labels Jul 24, 2024
@a74nh
Copy link
Contributor

a74nh commented Jul 30, 2024

priority:3 for RC1 snap : Not required, but it'd be nice to have for maintainability.

@a74nh a74nh modified the milestones: 9.0.0, 10.0.0 Aug 12, 2024
@a74nh a74nh self-assigned this Aug 21, 2024
@a74nh a74nh mentioned this issue Sep 6, 2024
Merged
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Sep 6, 2024
@kunalspathak kunalspathak added Priority:2 Work that is important, but not critical for the release and removed Priority:3 Work that is nice to have labels Sep 20, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@a74nh a74nh

Labels
arch-arm64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI arm-sve Work related to arm64 SVE/SVE2 support in-pr There is an active PR which will close this issue when it is merged Priority:2 Work that is important, but not critical for the release
Projects
None yet
Milestone
10.0.0
Development

Successfully merging a pull request may close this issue.

ARM64-SVE: refactor lsra buildHWIntrinsic a74nh/runtime
4 participants
@TIHan @a74nh @kunalspathak @JulieLeeMSFT