Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: SVE Cleanup - Fix alphabetical order of APIs #104834

Closed
TIHan opened this issue Jul 12, 2024 · 5 comments
Closed

JIT: SVE Cleanup - Fix alphabetical order of APIs #104834

TIHan opened this issue Jul 12, 2024 · 5 comments
Assignees
@a74nh
Labels
arch-arm64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI arm-sve Work related to arm64 SVE/SVE2 support Priority:2 Work that is important, but not critical for the release
Milestone
9.0.0

Comments

@TIHan
Copy link
Contributor

TIHan commented Jul 12, 2024

We have several SVE APIs that are not perfectly alphabetized; we should take some time and make sure they are all ordered properly.

Also mentioned here: #104704 (comment)
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Jul 12, 2024
@TIHan TIHan mentioned this issue Jul 12, 2024
Merged
@TIHan TIHan removed the untriaged New issue has not been triaged by the area owner label Jul 12, 2024
@TIHan TIHan added this to the 9.0.0 milestone Jul 12, 2024
@jeffschwMSFT jeffschwMSFT added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 15, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@JulieLeeMSFT JulieLeeMSFT added arm-sve Work related to arm64 SVE/SVE2 support Priority:3 Work that is nice to have labels Jul 24, 2024
@a74nh
Copy link
Contributor

a74nh commented Jul 29, 2024

I assume this only applies to the .cs files because those are the only customer facing ones.
However, it would be nice to ensure hwintrinsiclistarm64sve.h is ordered too.

The autogenerated files should be alphabetically correct.
Checking those vs the checked in versions would be a useful start.

@a74nh a74nh mentioned this issue Jul 29, 2024
Closed
@a74nh a74nh assigned a74nh and unassigned SwapnilGaikwad Jul 30, 2024
@a74nh
Copy link
Contributor

a74nh commented Jul 30, 2024

Looks like there are quite a few formatting issues in addition to what is mentioned here.

I'll use this defect for any formatting issue we fix in Sve.cs and System.Runtime.Intrinsics.cs

@a74nh a74nh added Priority:2 Work that is important, but not critical for the release and removed Priority:3 Work that is nice to have labels Jul 30, 2024
@a74nh
Copy link
Contributor

a74nh commented Jul 30, 2024

Switching up to priority:2 because these files are seen by end users and are fairly messy right now

@a74nh a74nh mentioned this issue Jul 30, 2024
Merged
@a74nh
Copy link
Contributor

a74nh commented Aug 1, 2024

Fixed by #105679

Raised #105796 to deal with the remaining issues in the file

@a74nh a74nh closed this as completed Aug 1, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@a74nh a74nh

Labels
arch-arm64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI arm-sve Work related to arm64 SVE/SVE2 support Priority:2 Work that is important, but not critical for the release
Projects
None yet
Milestone
9.0.0
Development

No branches or pull requests
5 participants
@TIHan @a74nh @SwapnilGaikwad @jeffschwMSFT @JulieLeeMSFT