From f46caec0fe8427b208ef18da8894410c87c47cf6 Mon Sep 17 00:00:00 2001 From: Ankit Jain Date: Fri, 3 Mar 2023 17:27:59 -0500 Subject: [PATCH] [wasm] Debugger tests - fix build (#82958) * [wasm] Debugger tests - fix build `/workspaces/runtime/src/mono/wasm/debugger/DebuggerTestSuite/TestHarnessProxy.cs(135,44): error CS8601: Possible null reference assignment` Started being hit with https://github.com/dotnet/runtime/pull/82479 . The other instances of this were fixed in https://github.com/dotnet/runtime/pull/82803 . * CI: Trigger all the wasm jobs, when roslyn is updated And this includes the debugger tests --- eng/pipelines/common/xplat-setup.yml | 5 +++++ src/mono/wasm/debugger/DebuggerTestSuite/TestHarnessProxy.cs | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/eng/pipelines/common/xplat-setup.yml b/eng/pipelines/common/xplat-setup.yml index 556c2361fbd78..8319fef9717db 100644 --- a/eng/pipelines/common/xplat-setup.yml +++ b/eng/pipelines/common/xplat-setup.yml @@ -110,6 +110,11 @@ jobs: eq(dependencies.evaluate_paths.outputs['DarcDependenciesChanged.Microsoft_NET_Workload_Emscripten_Current_Manifest-8_0_100-preview_3'], true), eq(dependencies.evaluate_paths.outputs['DarcDependenciesChanged.Microsoft_DotNet_Build_Tasks_Workloads'], true), eq(dependencies.evaluate_paths.outputs['DarcDependenciesChanged.System_Runtime_TimeZoneData'], true), + eq(dependencies.evaluate_paths.outputs['DarcDependenciesChanged.Microsoft_Net_Compilers_Toolset'], true), + eq(dependencies.evaluate_paths.outputs['DarcDependenciesChanged.Microsoft_CodeAnalysis'], true), + eq(dependencies.evaluate_paths.outputs['DarcDependenciesChanged.Microsoft_CodeAnalysis_CSharp'], true), + eq(dependencies.evaluate_paths.outputs['DarcDependenciesChanged.Microsoft_CodeAnalysis_Analyzers'], true), + eq(dependencies.evaluate_paths.outputs['DarcDependenciesChanged.Microsoft_CodeAnalysis_NetAnalyzers'], true), eq(dependencies.evaluate_paths.outputs['DarcDependenciesChanged.Microsoft_NET_ILLink_Tasks'], true)) ] - ${{ each variable in parameters.variables }}: diff --git a/src/mono/wasm/debugger/DebuggerTestSuite/TestHarnessProxy.cs b/src/mono/wasm/debugger/DebuggerTestSuite/TestHarnessProxy.cs index 371a8e954d751..3fd1aec644980 100644 --- a/src/mono/wasm/debugger/DebuggerTestSuite/TestHarnessProxy.cs +++ b/src/mono/wasm/debugger/DebuggerTestSuite/TestHarnessProxy.cs @@ -132,7 +132,7 @@ public static void RegisterProxyExitState(string id, RunLoopExitState status) s_statusTable[id] = status; // we have the explicit state now, so we can drop the reference // to the proxy - s_proxyTable.TryRemove(id, out WeakReference _); + s_proxyTable.TryRemove(id, out _); if (s_exitHandlers.TryRemove(intId, out WeakReference>? handlerRef) && handlerRef.TryGetTarget(out Action? handler))