Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert compiling dotnet/runtime in NullableWalker #67040

Closed
jaredpar opened this issue Feb 24, 2023 · 0 comments · Fixed by #67468
Closed

Assert compiling dotnet/runtime in NullableWalker #67040

jaredpar opened this issue Feb 24, 2023 · 0 comments · Fixed by #67468
Assignees
Milestone

Comments

@jaredpar
Copy link
Member

jaredpar commented Feb 24, 2023

When compiling dotnet/runtime with the latest compiler in Debug we hit the following assert in the nullable walker (around line 7391).

            Debug.Assert(false); // If this assert fails, add an appropriate test.

The line of code which is causing the assert is the following:

https://github.com/dotnet/runtime/blob/f9ebd42d05ca88f086d472832487fbccfc7fe4ac/src/tools/illink/src/ILLink.Shared/TrimAnalysis/HandleCallAction.cs#L1166-L1168

Found while digging into dotnet/runtime#82467

@jaredpar jaredpar assigned RikkiGibson and cston and unassigned RikkiGibson Feb 24, 2023
@jaredpar jaredpar added this to the 17.6 milestone Feb 24, 2023
@jaredpar jaredpar added the untriaged Issues and PRs which have not yet been triaged by a lead label Feb 27, 2023
@cston cston removed the untriaged Issues and PRs which have not yet been triaged by a lead label Mar 23, 2023
@cston cston modified the milestones: 17.6, 17.7 Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants