Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Windows/x64: 4 Improvements on 8/7/2024 8:05:53 AM #39573

Closed
performanceautofiler bot opened this issue Aug 7, 2024 · 4 comments
Closed

[Perf] Windows/x64: 4 Improvements on 8/7/2024 8:05:53 AM #39573

performanceautofiler bot opened this issue Aug 7, 2024 · 4 comments

Comments

@performanceautofiler
Copy link

Run Information

Name Value
Architecture x64
OS Mac OS X 10.18
Queue IPhone
Baseline dee8a8be71d755a1d27537ea8b3c59ee2a3d49c5
Compare 47ebcf3831a4a9b43d9abb19c21e4d66752e1d7c
Diff Diff
Configs CompilationMode:tiered, HybridGlobalization:true, iOSStripSymbols:false, RunKind:ios_scenarios, RuntimeType:nativeaot

Improvements in SOD - iOS HelloWorld NativeAOT .app Size nollvm symbols

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
4.32 MB 4.31 MB 1.00 0.00 True
4.32 MB 4.31 MB 1.00 0.00 True
4.32 MB 4.31 MB 1.00 0.00 True
4.32 MB 4.31 MB 1.00 0.00 True

graph
graph
graph
graph
graph
graph
graph
graph
graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'SOD - iOS HelloWorld NativeAOT .app Size nollvm symbols*'

SOD - iOS HelloWorld NativeAOT .app Size nollvm symbols

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@matouskozak
Copy link
Member

Small improvement, likely caused by dotnet/runtime#105945 @MichalStrehovsky !

@MichalStrehovsky
Copy link
Member

Small improvement, likely caused by dotnet/runtime#105945 @MichalStrehovsky !

Nice. My guess would be dotnet/runtime#104148, but 45 also probably contributed.

@matouskozak
Copy link
Member

I tried extracting the shortest range and only 45 pop-out to me as likely caused dotnet/runtime@af5a23c...c94cacb. In the range containing 48, no changes in measurements were recorded. Did it show improvements in local measurements? If so, perhaps something is off in the testing infra...

@MichalStrehovsky
Copy link
Member

Hm, it might be 45 after all, even though 45 wasn't a size fix, just deleting some dead code that happened to save size. I ran measurements on both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants