Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Linux/arm64: 1 Regression on 3/3/2023 10:27:59 PM #13816

Closed
performanceautofiler bot opened this issue Mar 9, 2023 · 2 comments
Closed

[Perf] Linux/arm64: 1 Regression on 3/3/2023 10:27:59 PM #13816

performanceautofiler bot opened this issue Mar 9, 2023 · 2 comments
Assignees
Labels
ampere arch-arm64 branch-refs/heads/main kind-micro Noise os-linux perf-regression PGO Applied if there were any profile guided optimization updates in the observed interval. runtime-coreclr

Comments

@performanceautofiler
Copy link

performanceautofiler bot commented Mar 9, 2023

Run Information

Architecture arm64
OS ubuntu 20.04
Baseline 86c04cf20b93ee96f5a276e8163b3adee2f8b0ac
Compare 507acb66e51ccc8fbe5e95f2a07ec4e3280b330c
Diff Diff

Regressions in System.Threading.Channels.Tests.SpscUnboundedChannelPerfTests

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
ReadAsyncThenWriteAsync - Duration of single invocation 149.33 ns 173.92 ns 1.16 0.15 False

graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

Payloads

Baseline
Compare

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Threading.Channels.Tests.SpscUnboundedChannelPerfTests*'

Payloads

Baseline
Compare

Histogram

System.Threading.Channels.Tests.SpscUnboundedChannelPerfTests.ReadAsyncThenWriteAsync


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 173.9163346095282 > 157.06420152866392.
IsChangePoint: Marked as a change because one of 3/3/2023 4:59:02 PM, 3/9/2023 2:25:45 AM falls between 2/28/2023 7:22:28 AM and 3/9/2023 2:25:45 AM.
IsRegressionStdDev: Marked as regression because -7.8638803298022 (T) = (0 -166.1184694457315) / Math.Sqrt((7.7297971606276805 / (23)) + (62.45933363152645 / (19))) is less than -2.0210753903043583 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (23) + (19) - 2, .025) and -0.09903515552783387 = (151.14936825287427 - 166.1184694457315) / 151.14936825287427 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@performanceautofiler performanceautofiler bot added ampere arm64 PGO Applied if there were any profile guided optimization updates in the observed interval. untriaged labels Mar 9, 2023
@EgorBo
Copy link
Member

EgorBo commented Mar 9, 2023

Either noise or Roslyn dotnet/runtime#82479

@AndyAyersMS
Copy link
Member

Seems to have recovered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ampere arch-arm64 branch-refs/heads/main kind-micro Noise os-linux perf-regression PGO Applied if there were any profile guided optimization updates in the observed interval. runtime-coreclr
Projects
None yet
Development

No branches or pull requests

3 participants