Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AssemblyLevel attributes missing / inconsistent #134

Closed
ericstj opened this issue Oct 14, 2024 · 1 comment
Closed

AssemblyLevel attributes missing / inconsistent #134

ericstj opened this issue Oct 14, 2024 · 1 comment
Assignees

Comments

@ericstj
Copy link
Member

ericstj commented Oct 14, 2024

As mentioned in dotnet/runtime#108806 (comment) assemblies built from this repo are missing CLSCompliantAttribute

Also some other metadata attributes, NeutralResourcesLanguage, DefaultDllImportSearchPathsAttribute.
 
They are also missing some other centrally applied attributes. dotnet/runtime handles these here:
https://github.com/dotnet/runtime/blob/6d23f64952d0f242c4dcc7cbb230a619be930309/eng/versioning.targets#L11-L57

A good test would be to compare the attributes present on the netstandard2.0 assembly of the old package and new to see if anything important is missing. You can disassemble them with your tool of choice (ildasm, ILSpy, GenAPI, etc).

Here's a sample:
Image

@ViktorHofer
Copy link
Member

Fixed by #135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants