Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Directly reference algorithm used in int sqrt #228

Closed
Arithmomaniac opened this issue Mar 11, 2024 · 3 comments · Fixed by #230
Closed

Directly reference algorithm used in int sqrt #228

Arithmomaniac opened this issue Mar 11, 2024 · 3 comments · Fixed by #230
Labels
question Further information is requested

Comments

@Arithmomaniac
Copy link
Contributor

https://github.com/dotnet/dotNext/blob/b20da06268a9b51ca4a767f308ad43bcf45c6460/src/DotNext/Numerics/Number.cs#L134C9-L134C121

It appears the actual algo is this exact answer to the question? https://math.stackexchange.com/a/4674078
@sakno
Copy link
Collaborator

sakno commented Mar 11, 2024

Rewritten using generic math, but fundamentally yes, it's the same.

@sakno sakno added the question Further information is requested label Mar 11, 2024
@Arithmomaniac
Copy link
Contributor Author

Arithmomaniac commented Mar 11, 2024 •
edited
Loading

Yeah, just a nitpick to link to the solution rather than the question. (I can make the PR myself if requested.)

@Arithmomaniac Arithmomaniac reopened this Mar 11, 2024
@sakno
Copy link
Collaborator

sakno commented Mar 11, 2024 •
edited
Loading

Yeah, link to the solution is more precise. You can submit PR.

Arithmomaniac added a commit to Arithmomaniac/dotNext that referenced this issue Mar 11, 2024
@Arithmomaniac
Update attribution of integer Sqrt in Number.cs
9b3c180 
Directly link to answer.

dotnet#228
@Arithmomaniac Arithmomaniac mentioned this issue Mar 11, 2024
Closed
@sakno sakno linked a pull request Mar 11, 2024 that will close this issue
Update attribution of integer Sqrt in Number.cs #229
Closed
This was referenced Mar 11, 2024
Closed
Merged
@sakno sakno linked a pull request Mar 11, 2024 that will close this issue
Update Number.cs #230
Merged
@sakno sakno closed this as completed Mar 11, 2024
@github-project-automation github-project-automation bot moved this to Closed in Core Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
Core
Status: Closed
Milestone
No milestone
2 participants
@Arithmomaniac @sakno