Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workshop Doc#5, Bonus Challenge : Text implies optional step, later stage assumes you've actually done it. #312

Open
SiliconOrchid opened this issue May 31, 2021 · 0 comments

Comments

@SiliconOrchid
Copy link

I have been working through the workshop in sequence (not using code startpoints). I think I've uncovered a minor omission in the guidance.


Related to text in section (note heading anchor in the following link to locate text):
https://github.com/dotnet-presentations/blazor-workshop/blob/master/docs/05-checkout-with-validation.md#bonus-challenge

Related to code:
bool isSubmitting property.

The text in this section suggests that the step is optional: i.e. "If you're keen and have time" and "Try declaring a bool isSubmitting".

Moving forward to the next document (note heading anchor in the following link to locate text):
https://github.com/dotnet-presentations/blazor-workshop/blob/master/docs/06-authentication-and-authorization.md#request-an-access-token ...
... the replacement code for Checkout.razor currently shows :

async Task PlaceOrder()
{
    isSubmitting = true;
. . .

At this point in the workshop, the text assumes that we have defined the bool. It's not an optional step, as implied in the previous stage:

It should be like this:

@code {
    bool isSubmitting;

    async Task PlaceOrder()
    {
        isSubmitting = true;

The code starting points for section 7 seems to be correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant