Skip to content
This repository has been archived by the owner on May 7, 2020. It is now read-only.

Home Page Stats counter broken. #43

Open
prkhandelwal opened this issue Sep 12, 2018 · 5 comments
Open

Home Page Stats counter broken. #43

prkhandelwal opened this issue Sep 12, 2018 · 5 comments

Comments

@prkhandelwal
Copy link
Member

prkhandelwal commented Sep 12, 2018

The stats counter values keep decreasing each time you scroll up and scroll down again.

@jongalloway
Copy link
Contributor

Can't reproduce - I think this might have been an issue during the deployment. Are you still seeing this?

@prkhandelwal
Copy link
Member Author

Yes the issue is still present. I am attaching a link to video reproducing the bug.

https://1drv.ms/v/s!AmPSCdCSeks4j8kgIl0svnIgLTb9TA

@andrewcahill
Copy link
Contributor

Yeah you will only see it once the browser window is smaller than the height between the top of the counters and the top of the browser window - effectively running this counter each time you scroll from top to bottom.

There is a javascript function within : https://github.com/dotnet/dotnetfoundation-website/blob/master/src/wwwroot/js/home.js between lines 5-25 to determine this range and will initiate the counter animation.

@prkhandelwal
Copy link
Member Author

The issue is, each time I scroll down from the top the range of counter keeps decreasing.

@jongalloway
Copy link
Contributor

Looks like this is a known issue with the jQuery plugin, a fix is to store the initial value: bfintal/Counter-Up#57 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants