Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Fix a bug in restoring from history in the Ogre repository.
What changed?
Added a test for restoring from history and a test for remoteRefs not changing on commit. Also added utility functions immutableMapCopy and mutableMapCopy.
How to test?
Run the new tests added and verify the correct behavior.
Why make this change?
Since maps store objects by reference, remoteRefs were mutated during commits so they became unusable.
https://macarthur.me/posts/maps-store-objects-by-reference/
📦 Published PR as canary version:
Canary Versions
✨ Test out this PR locally via: