Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UVE: Research if isTraditionalPage, canEditPage, and pageIsLocked Properties in UVEStore Can Be Computed #30760

Open
rjvelazco opened this issue Nov 25, 2024 · 0 comments

Comments

@rjvelazco
Copy link
Contributor

rjvelazco commented Nov 25, 2024

Task

Research if isTraditionalPage, canEditPage, and pageIsLocked properties in UVEStore can be computed.

Description

The properties isTraditionalPage, canEditPage, and pageIsLocked in the UVEStore depend on pageAPIResponse. These properties are currently primary store properties, but they may be more suitable as computed properties. We need to evaluate if these properties should be converted to computed properties to ensure proper implementation of the SignalStore pattern.

Proposed Objective

Core Features

Proposed Priority

Priority 3 - Average

Acceptance Criteria

  • Review the isTraditionalPage, canEditPage, and pageIsLocked properties in the UVEStore.
  • Determine if these properties should be converted to computed properties based on their dependency on pageAPIResponse.
  • Ensure that the SignalStore pattern is implemented correctly.
  • Update the store implementation if necessary.
  • Verify that the application functions correctly after the changes.
  • Ensure that all unit tests pass successfully.

References

@rjvelazco rjvelazco changed the title GD: UVE: Research if isTraditionalPage, canEditPage, and pageIsLocked Properties in UVEStore Can Be Computed Nov 25, 2024
@rjvelazco rjvelazco moved this from New to Gardening Day Backlog in dotCMS - Product Planning Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Gardening Day Backlog
Development

No branches or pull requests

1 participant