Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static Push can not push to some regions #12267

Closed
chrismccracken opened this issue Aug 7, 2017 · 11 comments
Closed

Static Push can not push to some regions #12267

chrismccracken opened this issue Aug 7, 2017 · 11 comments

Comments

@chrismccracken
Copy link
Contributor

chrismccracken commented Aug 7, 2017

Static configuration as follows:

aws_access_key=<REDACTED>
aws_secret_access_key=<REDACTED>
aws_bucket_name=prod-ohio-static.<REDACTED>.dotcmscloud.com
aws_bucket_region=us-east-2

https://gist.github.com/chrismccracken/cde1973cf86af04d920d6096dd7420ba

@chrismccracken
Copy link
Contributor Author

chrismccracken commented Aug 7, 2017

Also, in this case the Static Published kept aggressively trying to republish even though it was never going to success. Error handling behavior is tough to get perfect, but in this case where we get a 400 from the AWS S3 API it should just fail.

@oarrietadotcms
Copy link
Contributor

I think the problem could be that we are creating a AmazonS3Client without specifying the Region and then the headBucket method says that:

... if the bucket is in a different region than the client is configured with

We can use this method: setRegion(Region region)

@dsilvam dsilvam added this to the Rex Current milestone Aug 7, 2017
@brentgriffin
Copy link
Contributor

might be related to #12187

nollymar added a commit that referenced this issue Aug 11, 2017
nollymar added a commit to dotCMS/dotcms-libs that referenced this issue Aug 11, 2017
@nollymar
Copy link
Contributor

nollymar commented Aug 11, 2017

To solve this issue I had to tackle 2 problems:

Some improvements in our logic was required. Hopefully, it will improve the performance as well.

PR Core P8: #12320
PR Enterprise P8: https://github.com/dotCMS/enterprise-2.x/pull/502
PR dotcms-libs: dotCMS/dotcms-libs#31

dsilvam added a commit to dotCMS/dotcms-libs that referenced this issue Aug 11, 2017
@nollymar
Copy link
Contributor

Important for testing: Different static push scenarios where content is pushed to:

  • Several endpoints in different regions, including us-east-2
  • Endpoints with non-existing/existing buckets

Also, please consider to push more than one host and multilingual content

@dsilvam
Copy link
Contributor

dsilvam commented Aug 11, 2017

PR Core (master): #12324
PR Enterprise (master): https://github.com/dotCMS/enterprise-2.x/pull/503

@shaydotcms
Copy link

Passed QA. Successfully pushed content to different regions such as us-east-2 / us-west-2 / ca-central-1 / sa-east-1

@nollymar nollymar removed their assignment Aug 28, 2017
dsilvam pushed a commit that referenced this issue Aug 29, 2017
* #12267 Solving issue with static push status. It got stuck in Publishing Bundle status

* #12267 Fixing issue related to static push status

* Removing commented lines
nollymar added a commit that referenced this issue Aug 29, 2017
* #12267 Solving issue with static push status. It got stuck in Publishing Bundle status

* #12267 Fixing issue related to static push status

* Removing commented lines
@dsilvam
Copy link
Contributor

dsilvam commented Aug 29, 2017

PR core (master): #12448
PR ee (master): https://github.com/dotCMS/enterprise-2.x/pull/523

dsilvam pushed a commit that referenced this issue Aug 29, 2017
* #12267 Solving issue with static push status. It got stuck in Publishing Bundle status

* #12267 Fixing issue related to static push status

* Removing commented lines
@dsilvam dsilvam modified the milestones: Rex Next, Rex Current Sep 12, 2017
@dsilvam
Copy link
Contributor

dsilvam commented Sep 12, 2017

Note to QA: Retest this after upgrade of Hazelcast

@shaydotcms
Copy link

Passed QA. Successfully pushed after Hazelcast upgrade to different regions such as us-east-2 / us-west-2 / ca-central-1 / sa-east-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants