Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR test coverage for vitest instead of jest #64

Open
2 tasks
ClaraUktar opened this issue Jul 4, 2024 · 0 comments
Open
2 tasks

Update PR test coverage for vitest instead of jest #64

ClaraUktar opened this issue Jul 4, 2024 · 0 comments

Comments

@ClaraUktar
Copy link

🧽 Maintenance Description

We need to update the job showing the test coverage for a PR to use vitest and corresponding coverage libraries, because we already have and will continue to replace jest with vitest in our codebase, and want to see test coverage for each PR.

✔️ Acceptance Criteria

  • Test coverage is shown for each PR in all repos using vitest
  • The coverage is also shown in case of failing tests

🔗 References and Tools

To show coverage for vitest, the following library could be used: https://github.com/davelosert/vitest-coverage-report-action

How to test changes:

  1. Create a branch in this repository containing the changes made to the workflows
  2. Create a branch in a repo where the tests should be executed, e.g. data-graph, which refers to the branch in this repo in its manage-pr workflow, e.g. uses: dot-base/.github/.github/workflows/manage-pr.yml@new-pr-coverage
  3. Create a PR from the branch in step 2. The updated workflow should then be executed on GitHub.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants