Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create workflow that lints shared workflows on PRs #62

Open
4 tasks
cheyer opened this issue May 22, 2024 · 0 comments
Open
4 tasks

Create workflow that lints shared workflows on PRs #62

cheyer opened this issue May 22, 2024 · 0 comments

Comments

@cheyer
Copy link
Collaborator

cheyer commented May 22, 2024

🚀 Feature Description

We recently had a change in the .github workflows that are shared across the repositories which led to all pipelines being broken. The error was (dotstudio example):

Caution

Invalid workflow file: .github/workflows/manage-pr.yml#L120
The workflow is not valid. dot-base/.github/.github/workflows/merge-release-pr.yml@main (Line: 120, Col: 11): Secret GH_BOT_PAT is required, but not provided while calling.

We can fix this by adding GH action PR workflows for this repo to, as in all other repos.

The workflow that is triggered for PRs here should invoke the manage-pr.yml workflow. This will ensure, that Github itself is parsing the manage-pr.yml workflow and all referenced other workflows.

Maybe we can customize the code-check step to include workflow linters, e.g.:

✔ Acceptance Criteria

  • Add workflow that is triggered by PRs and uses manage-pr.yml
  • Customize code-check step to also handle linting for workflows
  • [Optional]: add workflow linting locally (add to Readme)
  • Make the check mandatory for merging (branch protection rules)
@cheyer cheyer self-assigned this May 22, 2024
@cheyer cheyer changed the title Create workflow that links shared workflows on PRs Create workflow that lints shared workflows on PRs Jun 18, 2024
@cheyer cheyer removed their assignment Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants