Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Damage Dealt/Healed for Pain Split #149

Open
jmynes opened this issue Aug 3, 2023 · 4 comments
Open

FEAT: Damage Dealt/Healed for Pain Split #149

jmynes opened this issue Aug 3, 2023 · 4 comments
Assignees
Labels
dank Good issue or request enhance New feature or request huh Further information is requested

Comments

@jmynes
Copy link

jmynes commented Aug 3, 2023

As a newcomer to competitive, I was not aware that Pain Split could still deal about 20% damage to a fully healed Snorlax with a fully healed Dusclops.

Currently this move always shows N/A:
image

Since we're already presupposing an HP EV/IV value for the opponent, and we know our own HP, the average health of both players should be estimatable.


Within the current UI, I'm unsure how to show the user that they'll heal.
Perhaps the existing damage estimate could have the Heal % value in green on the left side of the -, and DMG % value on the right in white/red?

A tooltip when hovering over the move could also be useful in explaining this.

@jmynes
Copy link
Author

jmynes commented Aug 3, 2023

In case this is a problem to be implemented upstream, I also opened an issue here:
smogon/damage-calc#572

Even if it's not added to the UI, querying the damage/healed calculation could make this easier.

@doshidak
Copy link
Owner

doshidak commented Nov 7, 2023

looks like someone seems to have opened a PR for this! I'll probably just wait for it to be merged (or if it hasn't been merged after some time, I'll just manually pull the changes).

@doshidak doshidak self-assigned this Nov 7, 2023
@doshidak doshidak added enhance New feature or request huh Further information is requested dank Good issue or request labels Nov 7, 2023
@jmynes
Copy link
Author

jmynes commented Nov 30, 2023

Looks like a new PR is tied to it, should be merged eventually :)
smogon/damage-calc#585

@jmynes
Copy link
Author

jmynes commented Jul 2, 2024

Woot! They merged Pain Split in damage-calc!
smogon/damage-calc#585

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dank Good issue or request enhance New feature or request huh Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants