fix bug in getOutpointsByAddress

dominant-strategies · Sep 22, 2024 · b684daf · b684daf
1 parent 76d94e6
commit b684daf
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 11 deletions.
diff --git a/src/providers/abstract-provider.ts b/src/providers/abstract-provider.ts
@@ -1484,16 +1484,15 @@ export class AbstractProvider<C = FetchRequest> implements Provider {
     }
 
     async getOutpointsByAddress(address: AddressLike): Promise<Outpoint[]> {
-        const outpoints: OutpointResponseParams[] = await this.#getAccountValue(
+        const outpointsObj: Record<string, OutpointResponseParams> = await this.#getAccountValue(
             { method: 'getOutpointsByAddress' },
             address,
             'latest',
         );
 
-        const outpointsArray = Array.isArray(outpoints) ? outpoints : [];
-
-        return outpointsArray.map((outpoint: OutpointResponseParams) => ({
-            txhash: outpoint.Txhash,
+        // Convert the object to an array of Outpoint objects
+        return Object.values(outpointsObj).map((outpoint: OutpointResponseParams) => ({
+            txhash: outpoint.TxHash,
             index: outpoint.Index,
             denomination: outpoint.Denomination,
         }));

diff --git a/src/providers/formatting.ts b/src/providers/formatting.ts
@@ -531,7 +531,7 @@ export interface QiTransactionResponseParams {
 }
 
 export interface OutpointResponseParams {
-    Txhash: string;
+    TxHash: string;
     Index: number;
     Denomination: number;
 }
diff --git a/src/wallet/qi-hdwallet.ts b/src/wallet/qi-hdwallet.ts
@@ -482,11 +482,7 @@ export class QiHDWallet extends AbstractHDWallet {
      */
     private async getOutpointsByAddress(address: string): Promise<Outpoint[]> {
         try {
-            const outpointsMap = await this.provider!.getOutpointsByAddress(address);
-            if (!outpointsMap) {
-                return [];
-            }
-            return Object.values(outpointsMap) as Outpoint[];
+            return await this.provider!.getOutpointsByAddress(address);
         } catch (error) {
             throw new Error(`Failed to get outpoints for address: ${address} - error: ${error}`);
         }