Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring #2

Open
domhnallmorr opened this issue Mar 24, 2024 · 0 comments
Open

Refactoring #2

domhnallmorr opened this issue Mar 24, 2024 · 0 comments

Comments

@domhnallmorr
Copy link
Owner

domhnallmorr commented Mar 24, 2024

Issue created to keep track on any refactoring ideas;

Model

Need separate class for race/practice session session. Possibly have a "Race" class and a "Practice" class which inherit from a "Session" class for common functionality.
Maybe make the standings_df as a separate class??

commentary_to_process, the pop method is being called within the controller to remove old messages, should probably put that back into the model itself.

View

Need better handling for lap time formatting. If lap time has not been set, should handle for that in the same function that formats time in min:ss:decimal. Also need to be consistency from model in whether a time has been set (i.e. None or "-" consistantly in the standings_df).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant