You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Issue created to keep track on any refactoring ideas;
Model
Need separate class for race/practice session session. Possibly have a "Race" class and a "Practice" class which inherit from a "Session" class for common functionality.
Maybe make the standings_df as a separate class??
commentary_to_process, the pop method is being called within the controller to remove old messages, should probably put that back into the model itself.
View
Need better handling for lap time formatting. If lap time has not been set, should handle for that in the same function that formats time in min:ss:decimal. Also need to be consistency from model in whether a time has been set (i.e. None or "-" consistantly in the standings_df).
The text was updated successfully, but these errors were encountered:
Issue created to keep track on any refactoring ideas;
Model
Need separate class for race/practice session session. Possibly have a "Race" class and a "Practice" class which inherit from a "Session" class for common functionality.
Maybe make the standings_df as a separate class??
commentary_to_process, the pop method is being called within the controller to remove old messages, should probably put that back into the model itself.
View
Need better handling for lap time formatting. If lap time has not been set, should handle for that in the same function that formats time in min:ss:decimal. Also need to be consistency from model in whether a time has been set (i.e. None or "-" consistantly in the standings_df).
The text was updated successfully, but these errors were encountered: