Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop .NET 6 #3183

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Drop .NET 6 #3183

wants to merge 1 commit into from

Conversation

martincostello
Copy link
Collaborator

Drop support for .NET 6.

Resolves #3087.

Leaving in draft for now - it's best to ship after a period of stability where we've fixed any known regressions caused by v7.

Drop support for .NET 6.
Resolves #3087.
@martincostello martincostello added dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code version-major A change suitable for release in a major version labels Nov 27, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.57%. Comparing base (6b5633c) to head (fc1ccf6).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3183      +/-   ##
==========================================
- Coverage   83.65%   83.57%   -0.08%     
==========================================
  Files          76       76              
  Lines        3175     3160      -15     
  Branches      536      536              
==========================================
- Hits         2656     2641      -15     
  Misses        519      519              
Flag Coverage Δ
Linux 83.57% <ø> (-0.08%) ⬇️
Windows 83.57% <ø> (-0.08%) ⬇️
macOS 83.57% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello added this to the v8.0.0 milestone Nov 27, 2024
@@ -1631,7 +1631,7 @@ Once your application has been setup with Swashbuckle (see [Getting Started](#ge

It's packaged as a [.NET Tool](https://learn.microsoft.com/dotnet/core/tools/global-tools) that can be installed and used via the dotnet SDK.

> :warning: The tool needs to load your Startup DLL and its dependencies at runtime. Therefore, you should use a version of the `dotnet` SDK that is compatible with your application. For example, if your app targets `net6.0`, then you should use version 6.0.xxx of the SDK to run the CLI tool. If it targets `net8.0`, then you should use version 8.0.xxx of the SDK and so on.
> :warning: The tool needs to load your Startup DLL and its dependencies at runtime. Therefore, you should use a version of the `dotnet` SDK that is compatible with your application. For example, if your app targets `net8.0`, then you should use version 8.0.xxx of the SDK to run the CLI tool. If it targets `net8.0`, then you should use version 8.0.xxx of the SDK and so on.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> :warning: The tool needs to load your Startup DLL and its dependencies at runtime. Therefore, you should use a version of the `dotnet` SDK that is compatible with your application. For example, if your app targets `net8.0`, then you should use version 8.0.xxx of the SDK to run the CLI tool. If it targets `net8.0`, then you should use version 8.0.xxx of the SDK and so on.
> :warning: The tool needs to load your Startup DLL and its dependencies at runtime. Therefore, you should use a version of the `dotnet` SDK that is compatible with your application. For example, if your app targets `net8.0`, then you should use version 8.0.xxx of the SDK to run the CLI tool. If it targets `net9.0`, then you should use version 9.0.xxx of the SDK and so on.

@Saibamen
Copy link
Contributor

Saibamen commented Nov 28, 2024

Please remove all #if NET6_0_OR_GREATER and #if NET7_0_OR_GREATER.

And if these IF statements have ELSE, update check to #if NET8_0_OR_GREATER. <----- EDIT: Umm, no, this is Swashbuckle.AspNetCore, not NSwag :D - we are not supporting .NET Framework

image

@martincostello
Copy link
Collaborator Author

martincostello commented Nov 28, 2024

No, that's unnecessary code churn that makes no difference just changing the version numbers.

The elses may be removable in some cases, but only for projects that don't target netstandard2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code version-major A change suitable for release in a major version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for .NET 6
3 participants