Remove 'DataGridEditCellEdit' from DataGrids

dolittle · Feb 23, 2024 · bd967d5 · bd967d5
1 parent 1f28d78
commit bd967d5
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 12 deletions.
diff --git a/Source/DesignSystem/molecules/DataGrid/DataGridEditCell.tsx b/Source/DesignSystem/molecules/DataGrid/DataGridEditCell.tsx
@@ -21,6 +21,7 @@ const textFieldBorderStyles = {
     },
 };
 
+// TODO: Gives an error at the moment.
 /**
  * Renders a editable text field cell in 'edit' mode in the DataGrid.
  */

diff --git a/Source/DesignSystem/molecules/DataGrid/helpers.tsx b/Source/DesignSystem/molecules/DataGrid/helpers.tsx
@@ -5,7 +5,7 @@ import React from 'react';
 
 import { GridColDef } from '@mui/x-data-grid-pro';
 
-import { DataGridEditCellEdit, DataGridEditCellView, DataGridSelectCellView, IconButton, StatusIndicator } from '../../index';
+import { DataGridEditCellView, DataGridSelectCellView, IconButton, StatusIndicator } from '../../index';
 
 export const dataTableDescription = `Data tables are an excellent way to organize vast amounts of data. Data tables should be easy to scan, 
             allowing the user to look for patterns and develop insights.
@@ -152,7 +152,6 @@ export const dummyEditCellColumns: GridColDef<DummyRowsProps>[] = [
         flex: 1,
         editable: true,
         renderCell: DataGridEditCellView,
-        renderEditCell: DataGridEditCellEdit,
     },
     {
         field: 'col2',
@@ -163,7 +162,6 @@ export const dummyEditCellColumns: GridColDef<DummyRowsProps>[] = [
         flex: 1,
         editable: true,
         renderCell: DataGridEditCellView,
-        renderEditCell: DataGridEditCellEdit,
     },
     {
         field: 'col3',

diff --git a/...icroserviceDetails/microserviceView/configuration/environmentVariable/DataGridColumns.tsx b/...icroserviceDetails/microserviceView/configuration/environmentVariable/DataGridColumns.tsx
@@ -5,7 +5,7 @@ import React from 'react';
 
 import { GridColDef } from '@mui/x-data-grid-pro';
 
-import { Button, DataGridEditCellEdit, DataGridEditCellView } from '@dolittle/design-system';
+import { Button, DataGridEditCellView } from '@dolittle/design-system';
 
 import { EnvironmentVariableTableRowParams } from './DataGrid';
 
@@ -16,15 +16,13 @@ export const dataGridColumns: GridColDef<EnvironmentVariableTableRowParams>[] =
         width: 330,
         editable: true,
         renderCell: DataGridEditCellView,
-        renderEditCell: DataGridEditCellEdit,
     },
     {
         field: 'value',
         headerName: 'Value',
         width: 330,
         editable: true,
         renderCell: DataGridEditCellView,
-        renderEditCell: DataGridEditCellEdit,
     },
     {
         field: 'isSecret',

diff --git a/...List/commandsListView/commandsListDataGrid/commandsListDetailPanel/DetailPanelColumns.tsx b/...List/commandsListView/commandsListDataGrid/commandsListDetailPanel/DetailPanelColumns.tsx
@@ -3,7 +3,7 @@
 
 import { GridColDef, GRID_CHECKBOX_SELECTION_COL_DEF } from '@mui/x-data-grid-pro';
 
-import { DataGridEditCellEdit, DataGridEditCellView, DataGridSelectCellView } from '@dolittle/design-system';
+import { DataGridEditCellView, DataGridSelectCellView } from '@dolittle/design-system';
 
 const parameterModeOptions = [
     {
@@ -35,7 +35,6 @@ export const commandsListDetailPanelColumns: GridColDef[] = [
         headerName: 'Description',
         editable: true,
         renderCell: DataGridEditCellView,
-        renderEditCell: DataGridEditCellEdit,
         minWidth: 200,
         flex: 1,
     },
@@ -44,7 +43,6 @@ export const commandsListDetailPanelColumns: GridColDef[] = [
         headerName: 'Parameter Name',
         editable: true,
         renderCell: DataGridEditCellView,
-        renderEditCell: DataGridEditCellEdit,
         minWidth: 200,
         flex: 1,
     },
@@ -53,7 +51,6 @@ export const commandsListDetailPanelColumns: GridColDef[] = [
         headerName: 'Default Value',
         editable: true,
         renderCell: DataGridEditCellView,
-        renderEditCell: DataGridEditCellEdit,
         minWidth: 200,
         flex: 1,
     },

diff --git a/...View/messageSection/tableSection/messageMappingDataGrid/MessageMappingDataGridColumns.tsx b/...View/messageSection/tableSection/messageMappingDataGrid/MessageMappingDataGridColumns.tsx
@@ -5,7 +5,7 @@ import React from 'react';
 
 import { GridColDef, GridRowId, GRID_CHECKBOX_SELECTION_COL_DEF } from '@mui/x-data-grid-pro';
 
-import { DataGridEditCellView, DataGridEditCellEdit, Tooltip } from '@dolittle/design-system';
+import { DataGridEditCellView, Tooltip } from '@dolittle/design-system';
 
 import { MappableTableColumn } from '../../../../../../../../../apis/integrations/generated';
 
@@ -46,7 +46,6 @@ export const getMessageMappingDataGridColumns = (disabledRows: GridRowId[]) => {
             editable: true,
             flex: 1,
             renderCell: DataGridEditCellView,
-            renderEditCell: DataGridEditCellEdit,
         },
     ] as GridColDef<DataGridTableListingEntry>[];
 };
-Original file line number
+Diff line change
@@ Expand Up / @@ -21,6 +21,7 @@ const textFieldBorderStyles = { @@
         },
     };
+    // TODO: Gives an error at the moment.
     /**
      * Renders a editable text field cell in 'edit' mode in the DataGrid.
      */
@@ Expand Down @@