Management new #705
Draft
Management new #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lled outside + simplifications. Co-authored-by: Jakob Høgenes <[email protected]>
…ally management tooling
Purpose is for showing in WebAPI, GraphQL, UI
Co-authored-by: Jakob Høgenes <[email protected]>
Co-authored-by: Jakob Høgenes <[email protected]>
Co-authored-by: Jakob Høgenes <[email protected]>
Co-authored-by: Jakob Høgenes <[email protected]>
The EventHandlers is now responsible for the registration. Right now it delegates it to the EventHandler itself. I think we should move the actual registration into EventHandlers. That would make the responsibility even clearer.
…nto 6.0.0-timeout
woksin
commented
Jul 8, 2022
Comment on lines
147
to
163
|
|
||
| async Task ValidateFilter() | ||
| { | ||
| _logger.ValidatingFilter(FilterDefinition.TargetStream); | ||
| var filterValidationResults = await _filterValidator.Validate(GetFilterProcessor, _cancellationTokenSource.Token).ConfigureAwait(false); | ||
|
|
||
| if (filterValidationResults.Any(_ => !_.Value.Succeeded)) | ||
| { | ||
| var firstFailedValidation = filterValidationResults.First(_ => !_.Value.Succeeded).Value; | ||
| _logger.FilterValidationFailed(FilterDefinition.TargetStream, firstFailedValidation.FailureReason); | ||
| throw new FilterValidationFailed(FilterDefinition.TargetStream, firstFailedValidation.FailureReason); | ||
| } | ||
|
|
||
| var filteredStreamDefinition = new StreamDefinition(FilterDefinition); | ||
| _logger.PersistingStreamDefinition(filteredStreamDefinition.StreamId); | ||
| await _streamDefinitions.Persist(Scope, filteredStreamDefinition, _cancellationTokenSource.Token).ConfigureAwait(false); | ||
| } |
There was a problem hiding this comment.
Suggested change
| async Task ValidateFilter() | |
| { | |
| _logger.ValidatingFilter(FilterDefinition.TargetStream); | |
| var filterValidationResults = await _filterValidator.Validate(GetFilterProcessor, _cancellationTokenSource.Token).ConfigureAwait(false); | |
| if (filterValidationResults.Any(_ => !_.Value.Succeeded)) | |
| { | |
| var firstFailedValidation = filterValidationResults.First(_ => !_.Value.Succeeded).Value; | |
| _logger.FilterValidationFailed(FilterDefinition.TargetStream, firstFailedValidation.FailureReason); | |
| throw new FilterValidationFailed(FilterDefinition.TargetStream, firstFailedValidation.FailureReason); | |
| } | |
| var filteredStreamDefinition = new StreamDefinition(FilterDefinition); | |
| _logger.PersistingStreamDefinition(filteredStreamDefinition.StreamId); | |
| await _streamDefinitions.Persist(Scope, filteredStreamDefinition, _cancellationTokenSource.Token).ConfigureAwait(false); | |
| } |
woksin
commented
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Summary of the PR here. The GitHub release description is created from this comment so keep it nice and descriptive.
Remember to remove sections that you don't need or use.
Added
Changed
Fixed
Removed
Security
Deprecated