Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not proceed if invalid parameter is passed #189

Open
turicas opened this issue Sep 13, 2022 · 0 comments
Open

Should not proceed if invalid parameter is passed #189

turicas opened this issue Sep 13, 2022 · 0 comments

Comments

@turicas
Copy link

turicas commented Sep 13, 2022

Description of problem

I was using an old version of postgres plugin and adding an option which was not supported on that version (--shm-size). Even after

How reproducible

Run in an older version of the plugin:

dokku postgres:create mypostgres --shm-size 2g

Steps to Reproduce

  1. Install old version
  2. Create passing a unsupported CLI parameter on that version

Actual Results

Error messages are shown but the container is created:

/var/lib/dokku/plugins/enabled/postgres/subcommands/create: illegal option -- -
/var/lib/dokku/plugins/enabled/postgres/subcommands/create: illegal option -- s
/var/lib/dokku/plugins/enabled/postgres/subcommands/create: illegal option -- h
       Waiting for container to be ready
       Creating container database
       Securing connection to database
...

Expected Results

Error message saying the parameters are not recognized and exit with error.

@josegonzalez josegonzalez transferred this issue from dokku/dokku-postgres Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants