From 424d1996fd0eaae7a2e6a23601ac92e65cb68bd0 Mon Sep 17 00:00:00 2001 From: Dennis Ploeger Date: Fri, 22 Dec 2023 15:58:41 +0100 Subject: [PATCH] feat: Support externalBaseUrl in helm chart --- charts/vmware-rest-proxy/templates/deployment.yaml | 4 ++++ charts/vmware-rest-proxy/values.yaml | 4 +++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/charts/vmware-rest-proxy/templates/deployment.yaml b/charts/vmware-rest-proxy/templates/deployment.yaml index 3c42675..cc34f55 100644 --- a/charts/vmware-rest-proxy/templates/deployment.yaml +++ b/charts/vmware-rest-proxy/templates/deployment.yaml @@ -54,6 +54,10 @@ spec: value: "{{ .Values.config.tlsSkipVerify }}" - name: VCENTER_PROXY_URL value: "{{ .Values.config.proxyUrl }}" + {{- if ne .Values.config.externalBaseUrl "" }} + - name: EXTERNAL_BASE_URL + value: {{ .Values.config.externalBaseUrl | quote }} + {{- end }} resources: {{- toYaml .Values.resources | nindent 12 }} {{- with .Values.nodeSelector }} diff --git a/charts/vmware-rest-proxy/values.yaml b/charts/vmware-rest-proxy/values.yaml index acadcb6..cd7d164 100644 --- a/charts/vmware-rest-proxy/values.yaml +++ b/charts/vmware-rest-proxy/values.yaml @@ -89,4 +89,6 @@ config: # config.tlsSkipVerify -- If set, will disable TLS verification for the API client tlsSkipVerify: "false" # config.proxyUrl -- Connect to the vCenter using this proxy - proxyUrl: "" \ No newline at end of file + proxyUrl: "" + # config.externalUrl -- External URL this service is reachable on + externalBaseUrl: "" \ No newline at end of file