Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Rails 7.1 #127

Closed
vseguin opened this issue Oct 16, 2023 · 2 comments
Closed

Support Rails 7.1 #127

vseguin opened this issue Oct 16, 2023 · 2 comments

Comments

@vseguin
Copy link

vseguin commented Oct 16, 2023

Hi 👋

https://github.com/doctolib/safe-pg-migrations/blob/master/Gemfile.lock - the Gemfile is preventing to upgrade to Rails 7.1, as both activerecord and activesupport are currently specified as < 7.1. Would be great to update this with Rails's new version.
@vseguin
Copy link
Author

vseguin commented Nov 2, 2023

Hello @CharlesDelannoy 👋

Wondering, any plans to do this? We'd like to upgrade our app to Rails 7.1 and this is a blocker - and we would like to keep the lib! Also happy to submit a PR if you think this is the best course of action!

@beauraF
Copy link
Member

beauraF commented Dec 12, 2023

Thanks @vseguin, it's now fixed by #133.

@beauraF beauraF closed this as completed Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vseguin @beauraF