Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

safe_mode whitelist for facterdb #191

Open
yakatz opened this issue May 28, 2024 · 3 comments
Open

safe_mode whitelist for facterdb #191

yakatz opened this issue May 28, 2024 · 3 comments

Comments

@yakatz
Copy link

yakatz commented May 28, 2024

Most people using the facterdb gem will be looking for the documentation about which versions of our factsets are included in the gem, as opposed to how to actually use the API, so we have a custom template to focus on that. Can facterdb be added to your whitelisted_gems list?

@lsegal
Copy link
Collaborator

lsegal commented May 28, 2024

Done :)

@yakatz
Copy link
Author

yakatz commented May 28, 2024

Thanks. It looks like it doesn't include the css (i.e. it is showing a 404), or if it does, the location is wrong. Any ideas?

@lsegal
Copy link
Collaborator

lsegal commented May 29, 2024

@yakatz this might be an issue with relative / global paths, or possibly due to the way we "install" custom plugin CSS. I think we might need to patch something to get that to work. Haven't had any custom templates/plugins that pull in assets before. One workaround would just be to inline the css where you need it for now (though this won't necessarily help with images unless you want to data-url those as well, not exactly ideal).

PS: noticed that you created a custom facterdb template and recreated all the template files-- you can avoid this by just using default and overriding individual templates that you actually need: https://github.com/docmeta/rubydoc.info/tree/main/templates/default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants