Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support appending volumes #60

Open
briceburg opened this issue Feb 22, 2017 · 0 comments
Open

support appending volumes #60

briceburg opened this issue Feb 22, 2017 · 0 comments
Milestone

Comments

@briceburg
Copy link
Member

briceburg commented Feb 22, 2017

It would be nice to devise a label strategy that allows appending values, for instance to add additional volumes. Currently you need to lookup the volumes label from upstream Dockerfile(s), and then copy this value while appending your changes.

E.g. the briceburg/ansible:2.1-dex image provides the label org.dockerland.dex.docker_volumes="~/.ssh/id_rsa:/dex/home/.ssh/id_rsa:ro \$ANSIBLE_CFG:\$ANSIBLE_CFG:ro ~/.ansible.cfg:/dex/home/.ansible.cfg:ro /etc/ansible/ansible.cfg"

If we want to add an additional volume in a downstream image, we have to copy this label and add the volume (say /nfs) -- org.dockerland.dex.docker_volumes="/nfs:/nfs:ro ~/.ssh/id_rsa:/dex/home/.ssh/id_rsa:ro \$ANSIBLE_CFG:\$ANSIBLE_CFG:ro ~/.ansible.cfg:/dex/home/.ansible.cfg:ro /etc/ansible/ansible.cfg" which becomes cumbersome and fragile.

@briceburg briceburg added this to the 1.0 milestone Mar 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant