[v0.19] revert: "bake: initial set of composable bake attributes" #2824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3ccbb88. Signed-off-by: Jonathan A. Sternberg <[email protected]>
jsternberg
force-pushed
the
bake-revert-composable-attributes
branch
from
d688bc5
to
cd017e9
Compare
crazy-max
changed the title
tonistiigi
approved these changes
Nov 27, 2024
crazy-max
force-pushed
the
bake-revert-composable-attributes
branch
6 times, most recently
from
c0c777a
to
9cd57f1
Compare
Signed-off-by: CrazyMax <[email protected]>
crazy-max
force-pushed
the
bake-revert-composable-attributes
branch
from
9cd57f1
to
8b02962
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 3ccbb88.
Seems to be related to empty variables. Need to add some unit tests and we'll try again with this feature in the future.