-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vendor: update buildkit to master #2035
Conversation
Note: test failures will be due to #2023 (comment), we need to update to point to the image built from Line 9 in da66629
|
86aae63
to
951a642
Compare
65a5c8e
to
b9aad03
Compare
Signed-off-by: Justin Chadwell <[email protected]>
Signed-off-by: Justin Chadwell <[email protected]>
Without this, we attempt to overwrite the previous display in the lines above which have been filled with logs from the monitor (see when used with `--invoke`). Signed-off-by: Justin Chadwell <[email protected]>
@dvdksn https://docs.docker.com/engine/reference/commandline/buildx_build/#progress looks outdated and should include new raw json mode: https://github.com/moby/buildkit/blob/c8b64d3d83fa7d0e9d5d4ab500df9d4cfe0e8b6d/util/progress/progressui/display.go#L135-L137 |
Updates Buildkit to the latest master commit (replaces #2023)
This pulls in relevant upstream changes such as:
client.Wait
backoffs moby/buildkit#4200client.Wait
method to bootstrap for remote driver #1934, which fixes the equivalent regression from After upgrade local CLI to 0.12 remote build stop working moby/buildkit#4164 in the remote driverrawjson
.quiet
- since the logic for parsing display modes has been moved into theprogressui.NewDisplay
, we need an upstream patch progress: add new quiet display mode moby/buildkit#4213 to add this display mode back in. This is actually good - having different sets of display modes between buildx and buildkit was confusing.