From bdbf9ed19b6e5efa3f753f449738b17bbbf4b58a Mon Sep 17 00:00:00 2001
From: Adam Becker <ad@mbecker.cc>
Date: Wed, 26 Oct 2016 14:04:35 -0700
Subject: [PATCH] add more options to confirmation popovers... (#291)

...rework the API a little bit, too.

cf https://github.com/dobtco/dvl-core/issues/289

I didn't add the advanced positioning, since that would best be
addressed upstream in Bootstrap.
---
 .../assets/stylesheets/application.css.scss   |  2 +-
 spec/dummy/app/views/home/components.rb       | 30 +++++++++--
 .../dvl/components/confirmations.coffee       | 52 +++++++++++--------
 ...popover.scss => confirmation_popover.scss} |  4 +-
 4 files changed, 60 insertions(+), 28 deletions(-)
 rename vendor/assets/stylesheets/dvl/components/{delete_popover.scss => confirmation_popover.scss} (76%)

diff --git a/spec/dummy/app/assets/stylesheets/application.css.scss b/spec/dummy/app/assets/stylesheets/application.css.scss
index 94a6a23..f1ada13 100644
--- a/spec/dummy/app/assets/stylesheets/application.css.scss
+++ b/spec/dummy/app/assets/stylesheets/application.css.scss
@@ -17,7 +17,7 @@
 @import 'dvl/components/pagination';
 @import 'dvl/components/pagination_compact';
 @import 'dvl/components/popovers';
-@import 'dvl/components/delete_popover';
+@import 'dvl/components/confirmation_popover';
 @import 'dvl/components/progress';
 @import 'dvl/components/sidebar_data';
 @import 'dvl/components/sidebar_nav';
diff --git a/spec/dummy/app/views/home/components.rb b/spec/dummy/app/views/home/components.rb
index f5cb61a..a3c165d 100644
--- a/spec/dummy/app/views/home/components.rb
+++ b/spec/dummy/app/views/home/components.rb
@@ -546,15 +546,39 @@ def main
       ul(class: 'delete_list') {
         li(class: 'js_delete_1') {
           text 'Project 1'
-          a(icon('minus-circle', 'aria-label' => 'Delete'), class: 'icon_secondary', 'data-confirm' => true, 'data-confirm-with' => 'popover', href: '/delete', 'data-method' => 'delete', 'data-remote' => true)
+          a(
+            icon('minus-circle', 'aria-label' => 'Delete'),
+            class: 'icon_secondary',
+            'data-confirm' => true,
+            'data-confirm-with' => 'popover',
+            href: '/delete',
+            'data-method' => 'delete',
+            'data-remote' => true
+          )
         }
         li(class: 'js_delete_2') {
           text 'Project 2'
-          a(icon('minus-circle', 'aria-label' => 'Delete'), class: 'icon_secondary', 'data-confirm' => 'This is an important record. <strong>It will be destroyed forever.</strong>', 'data-confirm-with' => 'popover', href: '/delete', 'data-method' => 'delete', 'data-remote' => true)
+          a(
+            icon('minus-circle', 'aria-label' => 'Delete'),
+            class: 'icon_secondary',
+            'data-confirm' => 'This is an important record. <strong>It will be destroyed forever.</strong>',
+            'data-confirm-with' => 'popover',
+            href: '/delete',
+            'data-method' => 'delete',
+            'data-remote' => true
+          )
         }
         li(class: 'js_delete_3') {
           text 'Project 3'
-          a(icon('minus-circle', 'aria-label' => 'Delete'), class: 'icon_secondary', 'data-confirm' => true, 'data-confirm-with' => 'popover', 'data-confirmation-options' => { 't_delete' => 'Archive' }.to_json, href: '/delete', 'data-method' => 'delete', 'data-remote' => true)
+          a(
+            icon('minus-circle', 'aria-label' => 'Delete'),
+            class: 'icon_secondary',
+            'data-confirm' => true,
+            'data-confirm-with' => 'popover',
+            'data-confirm-text' => 'Archive',
+            href: '/delete',
+            'data-method' => 'delete',
+            'data-remote' => true)
         }
       }
     }, sub: true, hint: 'Popovers can contain headers and alternate button text.'
diff --git a/vendor/assets/javascripts/dvl/components/confirmations.coffee b/vendor/assets/javascripts/dvl/components/confirmations.coffee
index 9376576..f856373 100644
--- a/vendor/assets/javascripts/dvl/components/confirmations.coffee
+++ b/vendor/assets/javascripts/dvl/components/confirmations.coffee
@@ -2,9 +2,11 @@ Dvl.Confirmations = {}
 
 class Dvl.Confirmations.Popover
   defaults:
-    t_cancel: 'Cancel'
-    t_delete: 'Delete'
-    popoverOpts: {}
+    'cancel-text': 'Cancel'
+    'cancel-class': ''
+    'confirm-class': 'error'
+    'confirm-text': 'Delete'
+    'popover-opts': {}
     # cancelCb:
 
   constructor: ($el, message, cb, opts = {}) ->
@@ -15,11 +17,14 @@ class Dvl.Confirmations.Popover
 
     @$el.data('popover-confirmation', @)
 
-    @options = $.extend {}, @defaults, @$el.data('confirmation-options'), opts
+    @options = $.extend {}, @defaults, opts
+
+    for i of @defaults
+      @options[i] = @$el.data(i) if @$el.data(i)?
 
     if message
       wrappedMessage = """
-        <div class='popover_delete_confirmation_message'>
+        <div class='popover_confirmation_message'>
           #{message}
         </div>
       """
@@ -28,15 +33,15 @@ class Dvl.Confirmations.Popover
       $.extend({
         html: true
         content: """
-          <div class='popover_delete_confirmation'>
+          <div class='popover_confirmation'>
             #{wrappedMessage || ''}
-            <a class='button error js-confirm-delete' href='#'>#{@options.t_delete}</a>
-            <a class='button js-cancel' href='#'>#{@options.t_cancel}</a>
+            <a class='button #{@options['confirm-class']} js-popover-confirm' href='#'>#{@options['confirm-text']}</a>
+            <a class='button #{@options['cancel-class']} js-popover-cancel' href='#'>#{@options['cancel-text']}</a>
           </div>
         """
         trigger: 'manual'
         placement: 'bottom'
-      }, @options.popoverOpts)
+      }, @options['popover-opts'])
     )
 
     @$el.popover('show')
@@ -44,11 +49,11 @@ class Dvl.Confirmations.Popover
     $tip = @$el.data('bs.popover').$tip
 
     $tip.on 'click', '.button', (e) =>
-      if $(e.target).hasClass('js-confirm-delete')
+      if $(e.target).hasClass('js-popover-confirm')
         @$el.trigger('confirm.dvl')
         cb()
 
-      if $(e.target).hasClass('js-cancel')
+      if $(e.target).hasClass('js-popover-cancel')
         @$el.trigger('cancel.dvl')
         @options.cancelCb?()
 
@@ -66,19 +71,22 @@ class Dvl.Confirmations.Popover
 
 class Dvl.Confirmations.Modal
   defaults:
-    t_generic: 'This is a destructive action. Please confirm.'
-    t_title: 'Are you sure?'
-    t_cancel: 'Cancel'
-    t_confirm: 'Confirm'
+    'generic-message': 'This is a destructive action. Please confirm.'
+    'title': 'Are you sure?'
+    'cancel-text': 'Cancel'
+    'confirm-text': 'Confirm'
     # cancelCb:
 
   constructor: ($el, message, cb, opts = {}) ->
-    @options = $.extend {}, @defaults, $el.data('confirmation-options'), opts
+    @options = $.extend {}, @defaults, opts
+
+    for i of @defaults
+      @options[i] = $el.data(i) if $el.data(i)?
 
-    message ||= @options.t_generic
+    message ||= @options['generic-message']
 
     $modal = Dvl.Modal.init(
-      Dvl.Modal.getHTML(title: @options.t_title),
+      Dvl.Modal.getHTML(title: @options['title']),
       removeOnClose: true
     )
 
@@ -90,9 +98,9 @@ class Dvl.Confirmations.Modal
         <div class='modal_footer'>
           <div class='modal_footer_primary'>
             <a class='button white' data-dismiss='modal'>
-              #{@options.t_cancel}
+              #{@options['cancel-text']}
             </a>
-            <button class='button error js-confirm-delete'>#{@options.t_confirm}</button>
+            <button class='button error js-popover-confirm'>#{@options['confirm-text']}</button>
           </div>
         </div>
       """
@@ -101,7 +109,7 @@ class Dvl.Confirmations.Modal
       $el.trigger('cancel.dvl')
       @options.cancelCb?()
 
-    $modal.one 'click', '.js-confirm-delete', ->
+    $modal.one 'click', '.js-popover-confirm', ->
       $el.trigger('confirm.dvl')
       cb()
 
@@ -109,4 +117,4 @@ class Dvl.Confirmations.Modal
         modal('hide').
         remove()
 
-    $modal.find('.js-confirm-delete').focus()
+    $modal.find('.js-popover-confirm').focus()
diff --git a/vendor/assets/stylesheets/dvl/components/delete_popover.scss b/vendor/assets/stylesheets/dvl/components/confirmation_popover.scss
similarity index 76%
rename from vendor/assets/stylesheets/dvl/components/delete_popover.scss
rename to vendor/assets/stylesheets/dvl/components/confirmation_popover.scss
index 8839649..dc56485 100644
--- a/vendor/assets/stylesheets/dvl/components/delete_popover.scss
+++ b/vendor/assets/stylesheets/dvl/components/confirmation_popover.scss
@@ -1,4 +1,4 @@
-.popover_delete_confirmation {
+.popover_confirmation {
   .button {
     display: block;
     padding-left: 1.5rem;
@@ -10,7 +10,7 @@
   }
 }
 
-.popover_delete_confirmation_message {
+.popover_confirmation_message {
   font-size: $fontSmall;
   text-align: center;
   margin-bottom: $rhythm;