Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SpelledPitch] Consider renaming Pitch.Spelling to PitchSpelling #215

Open
jsbean opened this issue Jun 18, 2019 · 1 comment
Open

[SpelledPitch] Consider renaming Pitch.Spelling to PitchSpelling #215

jsbean opened this issue Jun 18, 2019 · 1 comment
Labels

Comments

@jsbean
Copy link
Member

jsbean commented Jun 18, 2019

When one uses Pitch.Spelling downstream, they need to import not only the SpelledPitch module, but also the Pitch module.

Instead, if we rename Pitch.Spelling to PitchSpelling, and pull Pitch.Spelling out from under the extension of Pitch, someone can use it at the appropriate level of abstraction.

It is worth auditing how much breaks downstream (though in the end it may be for the better).

@jsbean
Copy link
Member Author

jsbean commented Jun 18, 2019

Of course, we can make Pitch.Spelling just a typealias, and add a deprecation warning:

extension Pitch {
    public typealias Spelling = PitchSpelling
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant