fix(Workable): use append write disposition for candidate subresources #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AstrakhantsevaAA
requested changes
Feb 26, 2024
| ) | ||
| yield candidates_resource | dlt.transformer( | ||
| name=f"candidates_{sub_endpoint}", write_disposition="merge" | ||
| name=f"candidates_{sub_endpoint}", write_disposition="append" |
There was a problem hiding this comment.
hey! you are right, we missed primary_key (or merge_key) here, candidates details response has no id key to make it primary. I think it makes more sense to set write_disposition='replace', to avoid data duplication.
There was a problem hiding this comment.
@AstrakhantsevaAA given that candidates is incremental, it will replace all existing data with just updated ones.
So for example,
- Initial sync syncs 100 candidates and 10 offers
- Candidate 20 now has an offer
- Second pull will replace candidate offers with only a single offer for candidate 20
While merge may have duplicates, it's better than the alternative of replacing everything
AstrakhantsevaAA
approved these changes
Mar 4, 2024
| ) | ||
| yield candidates_resource | dlt.transformer( | ||
| name=f"candidates_{sub_endpoint}", write_disposition="merge" | ||
| name=f"candidates_{sub_endpoint}", write_disposition="append" |
AstrakhantsevaAA
added
the
ci from fork
|
@ethanve can you rebase on master pls? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tell us what you do here
Given that there's no primary key set for candidate sub-resources, we should just use
appendverified source)Relevant issue
issue #
More PR info