Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation error in for custom auth classes #2129

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

burnash
Copy link
Collaborator

@burnash burnash commented Dec 9, 2024

Fixes #2122

Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for dlt-hub-docs canceled.

Name Link
🔨 Latest commit e03801d
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/675ab64333b0d100080295a6

@burnash burnash requested a review from rudolfix December 9, 2024 17:04
Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@burnash LGTM. we still miss a unit test for add_value_to_literal in test_typing.py. reason: this is hacky so we want to test it for all OS/python combinations

@burnash
Copy link
Collaborator Author

burnash commented Dec 12, 2024

@rudolfix I've added the test. As discussed imo the better solution is to create a special extensible type for this

Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@burnash burnash merged commit 3a8dfa7 into devel Dec 12, 2024
56 of 59 checks passed
@burnash burnash deleted the fix/2122-validation-error-for-custom-registered-auth branch December 12, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Registering custom auth class leads to DictValidationException with REST API source
2 participants