chore: devenv environment #2083
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs canceled.
|
joscha
force-pushed
the
joscha/devenv-scaffold
branch
from
279118f
to
9141ee4
Compare
joscha
commented
Nov 21, 2024
| ''; | ||
|
|
||
| # https://devenv.sh/pre-commit-hooks/ | ||
| git-hooks.hooks.lint = { |
There was a problem hiding this comment.
this runs the linter before commit. Can be omitted by passing -n, however I am also happy to remove this, if in question.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a Devenv environment to the repository which allows immediate development w/o have to worry about local installation of dependencies (make, python, poetry, etc.).
Devenv is using
nixunder the hood, which provides a reproducible environment due to the fact that it controls the whole dependency closure. That means that the files in this PR would ensure that all developers would use the same version of make, python, poetry, etc. for their local development of dlt, which reduces a whole bunch of problems when talking about issues, opening pull requests, etc.If the system has
direnvanddevenvinstalled everything is automatic.After activating the environment,
setupcan be run, which calls out tomake dev.Also happy to swap this for a raw nix flake or even a nix-shell if devenv is too bleeding edge.