Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As of 0.13 the option "Show key selection dialog when a client program requests a list of all keys" applies even if only one key is mounted #354

Open
Adambean opened this issue Aug 18, 2022 · 2 comments
Labels

Comments

@Adambean
Copy link

The option "Show key selection dialog when a client program requests a list of all keys" is very grand when multiple keys are mounted so you can obviously pick the key you intend to use.

However prior to version 0.13 this option would only apply if you have multiple keys mounted. If you had just one key mounted it would silently not happen as you've only got one key to choose from anyway.

Was this an intentional change? If so I'd suggest having a supplementary option "Only show selection dialog if multiple keys are mounted" so the previous behaviour can occur.

@dlech dlech added the bug label Aug 18, 2022
@dlech
Copy link
Owner

dlech commented Aug 18, 2022

No, I don't think this was intentional.

@Adambean
Copy link
Author

Thanks for confirming.

It's not terrible that this has started to happen. Perhaps some users may want to explicitly be asked and given the opportunity to decline a key being used automatically. Though the list would need to show who (remote address) is asking.

I'm open to this being discussed either way really. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants