Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2nd try at __rvalue(expression) #17494

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

2nd try at __rvalue(expression) #17494

wants to merge 1 commit into from
+318 −149

Conversation

WalterBright
Copy link
Member

as in #17050

@WalterBright WalterBright requested a review from ibuclaw as a code owner December 8, 2024 07:08
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#17494"

@thewilsonator thewilsonator added Review:Needs Changelog A changelog entry needs to be added to /changelog Review:Needs Spec PR A PR updating the language specification needs to be submitted to dlang.org Review:Needs Tests labels Dec 8, 2024
@WalterBright WalterBright force-pushed the __rvalue2 branch 5 times, most recently from 8ea2029 to bbe7d55 Compare December 8, 2024 19:48
@WalterBright WalterBright mentioned this pull request Dec 8, 2024
Open
@WalterBright
Copy link
Member Author

Something is wrong with the CI. See #17496

@WalterBright WalterBright force-pushed the __rvalue2 branch 13 times, most recently from d7ec407 to 8d00e97 Compare December 10, 2024 08:18
@WalterBright
Copy link
Member Author

Finally, some real progress.

@WalterBright WalterBright force-pushed the __rvalue2 branch 2 times, most recently from 51700ae to 3c180ae Compare December 10, 2024 22:00
@WalterBright
Copy link
Member Author

merged into #17050

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibuclaw ibuclaw Awaiting requested review from ibuclaw ibuclaw is a code owner

Assignees
No one assigned
Labels
Review:Needs Changelog A changelog entry needs to be added to /changelog Review:Needs Spec PR A PR updating the language specification needs to be submitted to dlang.org Review:Needs Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WalterBright @dlang-bot @thewilsonator