Extract dsymbol.addComment to dsymbolsem and turn it into a visitor #17110
+74
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request and interest in making D better, @ancamaxim! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#17110" |
ancamaxim
force-pushed
the
AddCommentVisitor
branch
4 times, most recently
from
fef8797 to
f6c0761
Compare
Implemented a visitor in dsymbolsem.d to successfully relocate addComment functions from attrib.d.
ancamaxim
force-pushed
the
AddCommentVisitor
branch
from
f6c0761 to
ffa44bc
Compare
RazvanN7
reviewed
Dec 10, 2024
| *p = Lexer.combineComments((*p).toDString(), comment.toDString(), true); | ||
| } | ||
| import dmd.dsymbolsem; | ||
| dmd.dsymbolsem.addComment(this, comment); |
There was a problem hiding this comment.
This method should also be extracted and put in the visitor.
RazvanN7
reviewed
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a visitor in dsymbolsem.d to successfully relocate addComment functions from attrib.d.