Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions should be chained #188

Closed
reckart opened this issue Jul 17, 2018 · 1 comment
Closed

Exceptions should be chained #188

reckart opened this issue Jul 17, 2018 · 1 comment

Comments

@reckart
Copy link
Member

reckart commented Jul 17, 2018

When an exception is caught and a new exception is generated, the old exception should be chained into the new one (unless there is a very good reason not to do it and this should be document in a code comment).

Also, when an exception is handled and thrown up/chained into a new exception, it should normally be unnecessary to log it because it should be expected that the exception is handled again at a higher level leading to the problem likely being logged twice.

@reckart reckart added this to the 1.2.1 milestone Jul 17, 2018
@reckart reckart removed this from the 1.2.1 milestone Jul 17, 2018
@reckart
Copy link
Member Author

reckart commented Jul 17, 2018

Already covered by #187.

@reckart reckart closed this as completed Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant