-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use icon sets exported from IcoMoon #57
Comments
I created a PR (#58) to suggest those changes |
any updates ? |
I just merged this in, I'll be pushing out a new build soon. Thanks again @rodrigopk! |
@rodrigopk @nadirHomeFriend Actually this just got me thinking. I think it might be better to give more power to the developer if I moved the responsibility of setting an |
The
react-native-vector-icons
has a methodcreateIconSetFromIcoMoon
, which creates an icon sets using an IcoMoon json configuration file.I would like to propose that the
StarRating
andStarButton
components had an optional prop to receive a IcoMoon configuration json, so that the user is able to use his own icon set if needed.Below follows an example to illustrate how we could use a prop for loading a custom icon set from a config json:
The text was updated successfully, but these errors were encountered: